Design comparison
SolutionDesign
Solution retrospective
Hello, Frontend Mentor coding community. This is my first try to code in Frontend Mentor🎉. I had a lots of fun doing the challenge. Any suggestions on how I can improve are welcome!
Community feedback
- @ASH2001princePosted about 2 years ago
Hello @YoussefTadarti congrats for your first attempt I got some tips for you
--HTML
- instead of adding the <div> as a container you should have put the <main> element.
- And the <div> card as a <article> and at the same time the <article> as a section,
--CSS
- Its kinda tricky positioning the card by using the margin i think its better using this code:
display: flex; justify-content: center; align-items: center;
- I did this project a couple days ago and this is how i designed the card => my main container:
.cards{ display: grid; grid-template-columns: repeat(4, auto); justify-content: center; align-items: center; }
hope you find my feedback helpful.
Marked as helpful1@YoussefTadartiPosted about 2 years agoHello @ASH2001prince thank you very much for your awesome feedback 🙏and thanks for this css and html tricks 🙏
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord