Four Card Section Challenge responsive - HTML & CSS

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Raink31, great work! 😊 I don't have a lot to comment on, just three things:

  1. Right now you're missing a main landmark, which is one of the reasons you're getting some issues in your report. I see that you have a class="main" for your container, but you still need the semantic HTML here, so just try changing that to <main class="main">.

  2. Great use of article! All you need to do is to change the title from a p to a heading tag, and that would get rid of the HTML validation issue of articles lacking headings.

  3. Right now, the font actually changes during loading, and that is because of the order of the lines in your code. You should try to have the font families load before the stylesheet, and right now, you have the font family in the style tags, which then is placed after the stylesheet links. What I would do is, I would just copy the <link> code from Google Fonts instead of the import one, and then make sure that link is placed before the stylesheet, not after.

  Hope this helps you out!

  Marked as helpful

  1
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Great job on the challenge just a tip, you can remove the body {width: 100vw;} on the body it results in a horizontal scrollbar at the bottom.

  Marked as helpful

  1