Four card page using flex + grid, with responsive typography

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Great work on this challenge, Sabrina, and congrats on submitting your first solution! Accuracy to the design will come with time and practice, so don't worry. Your overall layout looks really good, it's just some of the spacings, etc that would need to be tweaked.

  I typically use rem units instead of em as they're more predictable because they only look at the font-size of the html element. Whereas em can get a little tricky as it is sized based on the closest ancestor with font-size declared. Different developers will take different approaches though, so if em works for you then that's great.

  Also, quick heads up that your GitHub repo link is broken. You can update it by clicking the 3 vertical dots at the top right of this page and updating the URL. That will make it easier for others to see your code.

  I hope you enjoyed the challenge. Keep up the great work!

  0