Design comparison
SolutionDesign
Solution retrospective
Hi Front End Community. I just finished this challenge and I would really appreciate feedbacks on it. Thanks.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Nwobodo Igwe! 👋
Good effort on this challenge! 👍 Your site looks great on my desktop view. 😄
I have a few suggestions for this solution.
- I would recommend adding some
padding
to thebody
element to prevent the elements from touching the browser edges. 😉 - I suggest making the below HTML markup as one
h1
instead of two. You can wrap the second text withspan
and then make it as a block element. This way the text would move to the next line.
<h1>Reliable, efficient delivery</h1> <h1>Powered by Technology</h1>
- For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make screen readers ignore the image. In this case, all images are purely decorative.
I hope this helps! Keep up the good work! 👍
1 - I would recommend adding some
- @RajSanjelPosted over 2 years ago
My suggestion
- Use semantic html tags Read here
- Make breakpoint of 1100px width since there is not spacing in right and left and this ruins the user experience and design looks kinda ugly.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord