Four Card Feature Selection using CSS GRID & Flex

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey there, Chris-Ann C.! 👋

  Nice job on this challenge! 👏 Your solution looks good and responds very nicely! 👍

  I'd like to suggest adding a max-width to the main container or wrapper to prevent the content of the page from becoming too stretched on extra-large screens. Also, I noticed that you put "aria-hidden: true" as the alt text for the icons in the feature cards. I suggest adding aria-hidden: true as an attribute and value itself if you'd like to hide the images from screen readers and/or replacing that with some more descriptive alt text (like "magnifying glass icon", for instance, or something). 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Chris-Ann C.•300

  @cdc2021Posted almost 4 years ago

  @ApplePieGiraffe

  Thank you for the time taken and feedback given on this challenge, much appreciated :)

  1
• 

  Jelmer Overeem•15

  @JelmerovereemPosted almost 4 years ago

  I think it's because the image from the "supervisor" is overlapping the karma title: image

  1

  ---

  

  Chris-Ann C.•300

  @cdc2021Posted almost 4 years ago

  @Jelmerovereem Thanks, solved!

  1