Design comparison
SolutionDesign
Solution retrospective
What improvements can be made to the shadows and can anyone help me with the borders for the cards?
Community feedback
- @web223devPosted over 4 years ago
Hi Akshat Shukla I checked your code. It is not recommended to give style directly in the HTML tag. You styled it directly inside the <hr> tag.
<footer> <hr color="#333" size="1px" width="95%" style="margin: auto;"> ...Solution:
- Remove all style in <hr> tag.
Answer:
<footer> <hr> // Remove here code. <p class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. ...
- Add style in style.css
Answer:
footer hr{ display: block; height: 1px; border: 0; border-top: 1px solid #333; width: 95%; margin: auto; }
3@Nemesis-ASPosted over 4 years ago@web223dev Thanks for your feedback, I've fixed it!
0 - @cortarelvaPosted over 4 years ago
use border-radius:5px; on the cards for start and tweak the px as you prefer. Read this: https://www.w3schools.com/css/css3_borders.asp
0 - @noga-aviatorPosted over 4 years ago
More blur, lighter color and maybe a little longer ?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord