Design comparison
Community feedback
- @CodeWithAlaminPosted almost 2 years ago
Hi @ioanaydgn👋 Great job on completing this challenge! 🥳
I would like to share a few suggestions on this solution if you don't mind.
-
Consider using semantic HTML tags instead of generic ones like div where appropriate. For example, you could use a
header
element for the top container andsection
elements for the box sections, as these tags convey the meaning and purpose of the content they contain more accurately. -
Instead of using a separate class for each column color (e.g.,
col-red
,col-cyan
, etc.), you could define a single class for the columns (e.g.,col
) and use the color property to set thecolor
of the column's top border. This would make your code more concise and easier to maintain. -
To make your code more maintainable and scalable, you could define variables for repeating values like colors, font sizes, and margin sizes. For example, you could define a
$primary-color
variable for the color of the column's top border, and a$font-size-large
variable for the font size of theh1
andh2
elements. Then, you could use these variables throughout your stylesheet instead of repeating the same values.
Overall, this is a very well done solution to the challenge. Great job!
I hope this feedback was helpful. 😊 Keep up the good work!👍
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord