Four card feature section with HTML + CSS (СSS Grid)

Community feedback

• 

  Lailton Batista•690

  @lailton-bPosted almost 5 years ago

  OMG, you sent it very well, wow!! The only thing I would say that you can improve is the shadows, do some research on material design and see how to make the shadows more real, it's really cool!

  3

  ---

  

  archdron•65

  @archdronPosted almost 5 years ago

  @lailton-b Thanks, I will definitely take a look 👍

  0
• 

  P

  Nitya Gulati•665

  @nityagulatiPosted almost 5 years ago

  The page looks good, Archdron. The code is clean and readable and I like that you split up the stylesheets, nice work! Is there a reason that you put the border-color for the cards as inline style in your HTML? I would recommend moving that to your external css.

  Have you worked with HTML5 semantic tags before? That's something you can work with in your next project. It helps with screen readers and accessibility as well.

  • What is HTML5 and what can I do with it
  • HTML5 advantages and disadvantages

  And you can also look up SMACSS architecture for organizing your styles, I think you might like it :) I'm currently working with it and it definitely makes life easier especially for bigger projects.

  2

  ---

  

  archdron•65

  @archdronPosted almost 5 years ago

  @nityagulati

  Have you worked with HTML5 semantic tags before? Never, but thanks for suggesting :D I'm actually three weeks into a self-paced WebDev course and with very little coding experience, so it's all kinda new to me.

  I'll make sure to check out SMACSS, but I think I need to properly wrap my mind around CSS first.

  0

  

  P

  Nitya Gulati•665

  @nityagulatiPosted almost 5 years ago

  @archdron Which course are you doing at the moment?

  Yeah just keep practicing and once you have a good grasp of CSS, you can look up SMACSS and naming conventions such as BEM to organize and maintain your code. You are doing great :)

  1

  

  archdron•65

  @archdronPosted almost 5 years ago

  @nityagulati This one. Looked like a good value to me. Are there any you would recommend?

  Regarding the occasional inline styling, I thought I'd just leave the specific, one-off things inline and move the bulk styling to separate files.

  0