Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Four Card Feature Section with HTML and SCSS

@sonmikrafft

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@OmprakashR

Posted

Hi,

Congratulations!!

I have some suggestions for the CSS media. No need to declare media as per the classes we can combine in one class.

Now:  
@media (min-width: 90em) {
  .container {
    height: 100vh;
  }
}
@media (min-width: 90em) {
  .card__item {
    max-height: 100%;
  }
  .card__item__big {
    flex-basis: 34rem;
  }
}

Change TO :
@media (min-width: 90em) {

  .container {
    height: 100vh;
  }
 
  .card__item {
    max-height: 100%;
  }
  .card__item__big {
    flex-basis: 34rem;
  }


}

this helps you to manage code and reusability and understanding.

Thank you!!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord