Four Card Feature Section with HTML and SCSS

Community feedback

• 

  Omprakash Rahangdale•900

  @OmprakashRPosted 5 months ago

  Hi,

  Congratulations!!

  I have some suggestions for the CSS media. No need to declare media as per the classes we can combine in one class.

  Now:  
  @media (min-width: 90em) {
    .container {
      height: 100vh;
    }
  }
  @media (min-width: 90em) {
    .card__item {
      max-height: 100%;
    }
    .card__item__big {
      flex-basis: 34rem;
    }
  }
  
  Change TO :
  @media (min-width: 90em) {
  
    .container {
      height: 100vh;
    }
   
    .card__item {
      max-height: 100%;
    }
    .card__item__big {
      flex-basis: 34rem;
    }
  
  
  }
  

  this helps you to manage code and reusability and understanding.

  Thank you!!

  Marked as helpful

  0