Four card feature section

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted almost 3 years ago

  Hey, glad to see you completing another challenge in here! Again, the site looks great, it is responsive and mobile state looks really great. Just to iterate on the responsiveness, it is seamless:>

  MikevPeeren already gave a tip on this one, just a little tip also on this one

  • Change the section tag into just a div since section alone is not informative when navigated as landmark using a screen-reader unless the section tag is labelled using aria-labelledby attribute or when a visible heading tag that describes the whole section.

  Again, really nice seeing your solution here in fem. Great job!

  Marked as helpful

  1

  ---

  

  Ahmed Besheer•90

  @ahmedbesheerPosted almost 3 years ago

  @pikapikamart Hi, it's nice to see you commenting on my solution again.

  and as usual with descriptive and useful information, and thank you for your words I'm appreciated it.

  for the section I wasn't sure about using it, and thanks to you for proving that my doubt was right, and I will replace it with a div.

  about MikevPeeren's comment, Do you think also it isn't necessary to use the function and I can stick with using the Rem units directly?

  and as I said really glad to see you here, and hope to see you again on my coming solutions :)

  1

  

  Raymart Pamplona•16,100

  @pikapikamartPosted almost 3 years ago

  @ahmedbesheer Glad that you find it useful again :>

  For that one, I haven't realized that on Mikev's comment, using a function as rem converter is really nice because you don't have to divide manually every pixel count by 16.

  I don't know why that was pointed out though, using functions in scss is a big help^^

  Marked as helpful

  1
• 

  MikevPeeren•2,100

  @MikevPeerenPosted almost 3 years ago

  Hey 👋,

  Good job 👏

  My only comment would be why are you using a function for rem to convert px to rem. Why not just use rem straightaway ?

  1

  ---

  

  Ahmed Besheer•90

  @ahmedbesheerPosted almost 3 years ago

  @MikevPeeren Hi, thanks for your comment 🙏.

  I used the function mainly because I'm lazy 😂, and I was always had to open a calculator to convert Px to Rem,

  and I just learned about functions from the course I'm currently watching, so I had to implement what I've learned.

  so I think there's no better solution than this to reduce my repetitive work.

  I hope that my answer helped you, and have a good day 🙂.

  0