Design comparison
SolutionDesign
Solution retrospective
Please give a feed back on the responsive design & the media queries in CSS
Community feedback
- @mattstuddertPosted almost 5 years ago
Nice work Liny and congrats on submitting your first solution! Here are a few pointers after taking a look at your code:
- I would add the
background-color
to thebody
instead of the.container
class here so that it stretches to the edge of the browser. - You've currently got
max-width: 375px
as your media query, which means the content doesn't fit the screen from376px
up to small tablet size. So I'd recommend having another look at this. - On a future project, I'd recommend trying
min-width
media queries instead ofmax-width
. It often leads to less CSS code and has the benefit of loading in fewer styles for mobile users.
I hope these tips help. Keep up the great work! 👍
0@LinyThomasPosted almost 5 years agoHi Sir, Thanks for looking into my code and giving your valuable feedback. I would surely take these points into consideration for my future challenges.
Thank you once again, Liny
0 - I would add the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord