four card feature section - using grid

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work on this challenge! Your solution looks great. Here are a couple of small pointers after taking a look at your code:

  • It's great to see you using CSS Grid to position the cards. It's such a powerful layout tool
  • I would say the tagline content would be better off as a paragraph instead of a h2, as I would describe it as a heading of any sort. This would then mean the h3 headings could be changed to h2.
  • I would try and make your class names a bit more descriptive. Instead of .div1, div2, etc I would have .supervisor, .karma, etc for this layout.
  • Have you ever tried using min-width media queries instead of max-width? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain.

  I hope these pointers help. Keep up the great work!

  1
• 

  nabil-ee•60

  @nabil-eePosted almost 5 years ago

  Thanks, I will look into first-mobile designing and try it on the next project

  0