Design comparison
SolutionDesign
Solution retrospective
Need feedback on how I could have structured the project better. More semantic HTML or how i could have been more efficient writing CSS.
Community feedback
- @mattstuddertPosted almost 5 years ago
Nice work, Herman! You've done a really good job on this challenge and structured your code well. I've got a couple of small recommendations after looking at your code:
- I would recommend staying away from IDs as CSS selectors. You've used them for the individual cards, which makes sense as they're unique. But I always just stay away from them entirely to keep the specificity of my selectors as low as possible. This helps keep the code more maintainable, especially as you start to work on larger projects.
- Have you ever tried using
min-width
media queries instead ofmax-width
? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain.
I hope these tips help. Keep up the great work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord