Design comparison
Solution retrospective
Hello Everyone. Please have a look at my code and be kind to give me your feedback. Thanks!
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @SamiaMahwash 👋🏻
I just have a quick suggestion about the icons. I'd suggest adding
aria-hidden
to the icons, because they're only for decoration. That's it from me 🙃I hope this was helpful 👨🏻💻 The project looks really close to the design, well done. Cheers 👾
Marked as helpful0 - @fidellimPosted about 3 years ago
Hi Samia,
Great work finishing the project! It works perfectly for all devices (mobile, tablet, desktop). Just some suggestions:
- You could try learning BEM methodology to organize the way you name your classes.
- You can organize the content of your file by using extensions in VS Code. An example of it is Prettier. This will make your code look cleaner and organize. Also, if you are not using a code editor like VS Code, it would be great to try it. It is one of the best code editors as there are lots of extensions you can use and you are able to access the terminal there directly.
I hope it helps :)
Marked as helpful0@Mahwash-AlyPosted about 3 years ago@fidellim I am using Atom. :) I will look into BEM. Thanks for the feedback!
1@fidellimPosted about 3 years ago@SamiaMahwash give VSCode a try if you have time :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord