Four card feature section using CSS Grid

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Really nice work on this challenge Teng, your solution looks great and scales down nicely to mobile. One small tweak I'd make in the HTML is to actually flip the .cards and .card elements so that .cards is a section and the smaller .card groups are div elements. A section is typically used for a larger grouping of themed content.

  Also, just a quick heads up that the "View Code" link is currently going to the /settings page on your repo, so it gives a 404. You can update the link to remove that, which will make it easier for people to see your code.

  Keep up the great work! 🙂

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @pyteng you're welcome! Here's a good resource from MDN about structural elements. You can then click on each one and learn more. It can definitely be a little confusing at first but it's fine once you go through it and understand the intricacies.

  0

  

  Teng•170

  @pytengPosted about 5 years ago

  @mattstuddert thanks for the feedback matt! still having trouble choosing between section / div and article when grouping elements. :D

  0