Design comparison
Solution retrospective
Feedbacks and suggestions are welcome!
Community feedback
- @FluffyKasPosted almost 3 years ago
Hey, good job on this one! The only thing I'd change is your alt texts. They're only decorative so you may as well leave them empty. Or, if you really want to keep them, there are guidelines you could consider when writing them ^^
Marked as helpful1@vencertorresPosted almost 3 years ago@FluffyKas Thank you for that link! I kept thinking if I should add an alt text for all
img
elements since the report is throwing errors on accessibility on my previous solutions for the other challenges.0 - @techantherePosted almost 3 years ago
Hey, your solution is perfectly fine! Well done! A few tips I will like to give, you should keep the icons' alt text to empty and then use
aria-hidden=true
for icons etc. Similarly in sections, you can set the aria-label attribute of each section to the id of the related h2 headings of a card, this is a good coding habbit for accessibility. Good luck :)Marked as helpful0 - @elliotlafave123Posted almost 3 years ago
Well done, I think your font actually looks better than the design :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord