Four card feature section using CSS Grid

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @chaman-rawat 👋🏻

  I've got some feedback for the project.

  • For the icons, add aria-hidden="true”, because they're for decoration. You can read more about aria-hidden here. For example:

  <img src="images/icon-team-builder.svg" alt="Team Builder">
  

  • Avoid, positioning items with just margins especially when you're trying to center them. Both Flexbox and Grid have things like align-items, justify-content, etc. you should use them for positioning.
  • Also, avoid fixed units for layouts such as pixels, try to use rems and percentages for things like width.
  • Lastly, to answer your question, there's no way to get accurate screen size from browser DevTools, because sometimes in DevTools things look superb for mobile viewport width, but when you open it on an actual phone some things may not look or work as excepted, but that's pretty rare nowadays.

  I hope this was helpful 👨🏻‍💻 other than that, for the first project you did a great job, well done. Cheers 👾

  Marked as helpful

  2

  ---

  

  Chaman•120

  @chaman-rawatPosted about 3 years ago

  Thank you @kens-visuals for giving a very helpful and detailed feedback to me. I will surely consider all this advises when I will work on my next projects.

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @chaman-rawat you're welcome 😇

  0