Four card feature section built with HTML and CSS
Design comparison
Solution retrospective
You think you can find inefficient code in my repository? let me know!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The intro heading and paragraph should be wrapped inside a
header
element.
- The “icons” serve no other purpose than to be decorative; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@rafdidactPosted almost 2 years agoHey! I really appreciate your suggestions. Already applied them.
0 - The intro heading and paragraph should be wrapped inside a
- @AdrianoEscarabotePosted almost 2 years ago
Hello Adán Estévez, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
<h1 class="light-heading">Reliable, efficient delivery</h1> <h1 class="bold-heading">Powered by Technology</h1>
The most appropriate in this case would be just an
h1
tag! containing the two contents, to make them break a line, we can use a max-width, and for the styling we can use a span element with the content that will be changed!The main tag must be present in every HTML document so that we can recognize the main content. To fix this, wrap the main content in the main tag. Users of assistive technology will have a better navigation experience on your site thanks to the use of HTML5 landmark elements.
The remainder is excellent.
I hope it's useful. 👍
Marked as helpful1@rafdidactPosted almost 2 years agoHey, Adriano!
Your advice was very useful. In fact, you got me finally reading through some documentation. Stuff's fixed and it looks more elegant than ever. Thank you.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord