Design comparison
Solution retrospective
Feel free to provide feedback. I will be very happy if you tell me how I can improve.
Community feedback
- @vanzasetiaPosted over 3 years ago
👋Hi Abdulrhman Kotb! My name is Vanza!
I have some feedback for this solution:
- On mobile screen size (<400px), the
padding-right
andpadding-left
is too big. Try to add more media query and reduce thepadding
to1.25rem
. - Use
rem
forfont-size
. It's simply becauserem
unit will allow the user to change their font size based on their setting. - As you can see from the design comparison, the
h1
andh2
font size is too small, try to make it bigger.
That's it! Hopefully this is helpful!
Marked as helpful1@abdo-kotbPosted over 3 years ago@vanzasetia Thanks a lot for your suggestions. They are really helpful.
Regarding the
h1
andh2
font size, I actually fixed them after the submission, but I don't have enough points to spend on updating the screenshot. 😅I would like to ask you a question, is it better to use
rem
orvw
forfont-size
? Because I searched about them and I couldn't know for sure which one I should use.Thanks again! And sorry for my bad English
0@vanzasetiaPosted over 3 years ago@abdo-kotb I recommend to use
rem
when you're just starting out, sincevw
will make the font size too small on small screen and make it too big on big screen.After you know how to use
clamp()
, which is a CSS Function, then you can combinerem
andvw
,it would look something like this:p { font-size: clamp(1rem, 1rem + 5vw, 1.5rem); }
That's it! Hopefully this is helpful!
0 - On mobile screen size (<400px), the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord