Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S β¨οΈ:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img src="./images/icon-team-builder.svg" alt="team-builder icon"> π <img src="./images/icon-team-builder.svg" alt="">
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @NehalSahu8055Posted over 1 year ago
Hello Coder π.
Congratulations on successfully completing the challenge! π
Few suggestions regarding design.
β¨ To properly center the container.
- USING FLEXBOX
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID
body{ min-height: 100vh; display: grid; place-items: center; }
β¨ For image like
.svg
aredecorative
which screen reader will not render it to beimportant
and skip it, so it make no sense to addalt
leave itblank
.β¨It would better if you use
either inline css or external css
not both.I hope you find this helpful.
Happy codingπ
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord