Four card feature section solution

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Z-ayat 👋🏻

  I have some feedback to help you fix the accessibility and HTML issues. Also, some other minor stuff.

  • First, let's tackle the main issues about semantic markup. This, <section class="container">...</section> should be <main class="container">...</main>, and it has to be the only main on the page. So 'id suggest changing every other <section> and <main> to a regular <div>. Here you can find each and every semantic tag. By fixing these you'll clear the most, if not all, of the issues in the report.
  • Next, I'd recommend pumping up font-size on desktop size. Let's say to 2.4rem
  • You should also add aria-hidden="true" to all the icons. For example <img src="images/icon-supervisor.svg" alt="" aria-hidden="true" class="">.
  • For the mobile view, headings should have text-align: center;

  I hope this was helpful 👨🏻‍💻 other than these, you did a really great job, keep it up. Cheers 👾

  Marked as helpful

  0
• 

  Zayat•310

  @Z-ayatPosted about 3 years ago

  Thanks for feedback, gonna re update the code <3

  0