f1r3• 120
@f1r3place
Posted
hi there! congratulations on completing the challenge
here's some feedback:
- love the semantic html and all the accessibility features, kudos for that!
- but I don't really agree with the usage of
<article>for cards. here's what MDN says about the<article>element: The <article> HTML element represents a self-contained composition in a document, page, application, or site, which is intended to be independently distributable or reusable (e.g., in syndication). I don't think the cards are self-contained compositions, because without the context of the website they don't make much sense - the css is quite readable, love the use of custom properties
- it's great you've added another breakpoint besides the one shown in the design, makes the website look good on every screen size
I guess that's about it. good luck on your next challenges!
0
