Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
Pretty happy with the overall result. This time I try to split up the layout into different boxes to easily oraganize my markup.
What challenges did you encounter, and how did you overcome them?Nothing in particular
What specific areas of your project would you like help with?Maybe I've absued a little bit Grid, but any suggestion is highly welcome! :D
Community feedback
- @f1r3placePosted 4 months ago
hi there! congratulations on completing the challenge
here's some feedback:
- love the semantic html and all the accessibility features, kudos for that!
- but I don't really agree with the usage of
<article>for cards. here's what MDN says about the<article>element: The <article> HTML element represents a self-contained composition in a document, page, application, or site, which is intended to be independently distributable or reusable (e.g., in syndication). I don't think the cards are self-contained compositions, because without the context of the website they don't make much sense - the css is quite readable, love the use of custom properties
- it's great you've added another breakpoint besides the one shown in the design, makes the website look good on every screen size
I guess that's about it. good luck on your next challenges!
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord