Design comparison
Solution retrospective
I would appreciate any tips or feedback :)
Community feedback
- @kbrandon19Posted almost 3 years ago
Hey @Sneflenie, your code is pretty clean which is a great thing but the only feedback I would offer is to be careful with naming classes. You have
html .cards
thenhtml .card
within it and if not careful can cause a problem, especially if there's 100s of lines of code. Try using names that describe more of what it could be like card-container, card-wrapper, etc. But try not to ponder on class names though haha, I have that problem sometimes, keep it simple. 👍🏾Marked as helpful1@SnefleniePosted almost 3 years ago@kbrandon19 Thank you! I will definitely keep that in mind 🙂
0 - @ChristBMPosted almost 3 years ago
Good job @Sneflenie I checked your code and it's ok. If you want to improve it, read more about semantic HTML tags and CSS BEM class notation. Semantic HTML tags BEM
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord