
Design comparison
SolutionDesign
Community feedback
- P@KonradJamPosted 16 days ago
Hello @Eng4atou!
Good job! I have some fixes for your code:
- Try using HTML5 semantics more efficiently.
<main> => <div class="container" <section class="content-container"> => <header class="content-container"> <section class="card-container"> => <main class="card-container"> <div class="card [name]-card"> => <section class="card [name]-card">
You can read more about HTML5 semantics in my post on LinkedIn
- Use relative units like
rem
orem
instead ofpx
. My publication about Relative Units on LinkedIn - Add some padding to the main container, because on the 1024px resolution, card are touching the edges of the page.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord