Four card feature section learning grid

Community feedback

• 

  Jonathan Hull•105

  @nanoaquilaPosted almost 5 years ago

  Your solution is really close to the original and that is good. I would recommend watching Jen Simmons(Layout Land) for some great insight into grid. As for the box-shadow using negative units can help achieve that soft shadow something like box-shadow: 0px 20px 68px -23px rgba(0,0,0,0.75); by making the spread negative (the 4th value) and increasing the blur (3rd value) you can get some really nice shadow effects. Great work.

  2

  ---

  

  Nahuel•30

  @NahuelDevPosted almost 5 years ago

  @nanoaquila Thanks for reply!, I didn't know about the negative units in the box shadow.

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work Nahuel! You've received some awesome feedback from @nanoaquila, so I'll add some thoughts on other areas of your code:

  • Your media query is set to max-width:375px, which means that from 376px to tablet size the content is too wide for the screen. I'd recommend reviewing your breakpoints and try to get the content looking good from mobile all the way up to desktop.
  • You're using IDs as selectors in your CSS. I'd recommend avoiding this as they're too specific and they can't be reused on the page. Instead, I'd stick to class, attribute, pseudo, and type selectors. You'll find that your CSS code will be much more maintainable, especially in larger projects, if you stick to these.

  I hope these tips help. Keep up the great work! 👍

  1