Design comparison
Solution retrospective
Hi! I would appreciate it if you could review my code and give feedback. Your feedback is very important to me, thank you very much!!!
Community feedback
- @VCaramesPosted about 2 years ago
Hey @keyztrokee, some suggestions to improve you code:
-
The heading is one single heading so the entire thing should be wrapped in a single <h1> Heading along with a Span Element.
-
I recommend adding a third layout to make the transition from mobile 📱 -> desktop 🖥 views smoother.
-
To give you HTML code structure, you want to set up your code in the following manner (Matt Studdert recommend this layout)
<body> <header></header> <main> <section> <div class="supervisor-card"></div> <div class="team-card"></div> <div class="karma-card"></div> <div class="calculator-card"></div> </section> </main> </body>
The Header Element represents introductory content.
The Main Element identifies the main content of the document.
The Section Element can be used to wrap content that is related to each other.
And since none of the cards make sense on their own, a simple Div will do for each card.
Happy Coding! 👻🎃
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord