Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
:)
What challenges did you encounter, and how did you overcome them?:)
What specific areas of your project would you like help with?:)
Community feedback
- @wcyin9Posted 7 months ago
Hi there, really great work!
One thing I would suggest is implementing
main
in your html code for ARIA landmark purposes. It would really help the screen readers know where they are on the page. There's also no need to giveheader
a class of header since you can just target header selector directly in CSS.In terms of headings, it's best practice to use
h1
toh6
in order. I noticed that you started withh3
, so you can useh1
andh2
instead ofdiv
first, before jumping toh3
.You did a very good job, keep up the great work!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord