Design comparison
Solution retrospective
Hello community, thankyou to anyone helping with my coding skills. This is my only question:
- Can I make each card position correctly in mobile mode without using the media query? Should I use min max values or is there another technique I'm ignorant about?
If you see anything that can help me get better at coding I would greatly appreciate it.
Community feedback
- @BonreyPosted over 3 years ago
Hi, Luis! π Your site looks great! It's responsive and works fine! However, I wouldn't use the
section
tag for cards (see your HTML ISSUES). The thing is, eachsection
should have a heading (one ofh2
-h6
elements) and the main part, but here there's simply no heading.2@luibernipPosted over 3 years agoHi @Bonrey! Thank you for taking the time to feedback my code. I had no idea about headings and sections, and now thanks to you I will apply it. I will take a visit into semantic HTML documentation.
Have a nice day, and once again, thankyou.
0@BonreyPosted over 3 years ago@luibernip you're welcome! Good luck with your coding! π
0 - @samuelpalaciosdevPosted over 3 years ago
Hi, Luisπ
Great job on this challenge. Your solution looks good and it scales pretty wellπ
I only suggest some things π:
-Maybe checking the HTML Structure I'd set the content as an entire section, not two different. They share relation.
I really like the way you approach this, have a nice day, keep coding!π
1@luibernipPosted over 3 years agoHi @samuelpalaciosdev. Thank you for that feedback, I feel sometimes my code lacks divisioning and sometimes it has too much. It is all about gaining experience in order to find the correct balance, and your feedback takes me another step forward into a better code.
Thanks for taking the time to help me. :)
Have a nice day!
0@samuelpalaciosdevPosted over 3 years agoI'm glad I helped you. Have a nice day and keep codingπ
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord