Skip to content
Submitted over 3 years ago

Four card feature section

dannebrob•130
@dannebrob
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

My second Frontend Mentor challange.

Please give me any feedback you can! Thanks in advance!

Community feedback

  • Grzegorz Sterczewski•680
    @gsterczewskiPosted over 3 years ago

    Hello dannebrob 👋, my name is Grzegorz.

    I like your solution, it's looking pretty good.

    I have a few small observations.

    • Your <p> element right now is too narrow on desktop, maybe consider giving it more space by reducing margin-left and margin-right on .info

    • There is not enought vertical space between .info and .card-container, you can easily fix it by adding margin-bottom or margin-top

    • I would rethink using vw and vh as a unit for margins, since it cause problems with responsiveness (try to resize page to 1024x1366 and see what happens)

    • Maybe figure out other way to limit width on .info without those horizontal margins.

    Other than that, I like it.

    I hope my sugestions will be useful to you

    Keep up the good work! 💪

    See you on the coding trail 😉

    Cheers!

    Marked as helpful
    0
    dannebrob•130
    @dannebrobPosted over 3 years ago

    @GSterczewski Thank you for the feedback! This really helps!

    0
  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @dannebrob, some suggestions to improve you code:

    • To give you HTML code structure, you want to set up your code in the following manner (Matt Studdert recommend this layout)
    <body>
   <header></header>
   <main>
      <section>
            <div class="supervisor-card"></div>
            <div class="team-card"></div>
            <div class="karma-card"></div>
            <div class="calculator-card"></div>
      </section>
   </main>
</body>

    The Header Element represents introductory content.

    The Main Element identifies the main content of the document.

    The Section Element can be used to wrap content that is related to each other.

    And since none of the cards make sense on their own, a simple Div will do for each card.

    • The heading is one single heading so the entire thing should be wrapped in a single <h1> Heading along with a Span Element.

    • Add a third layout to make the transition from mobile 📱 -> desktop 🖥 views smoother.

    • The icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

    Happy Coding! 👻🎃

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord