Four card feature section - CSS Open Props & Vite
Design comparison
Solution retrospective
I learned to use CSS Open Props in this project. I think next time I will use Tailwind CSS.
What challenges did you encounter, and how did you overcome them?No real challenges, but I look forward to the next project.
What specific areas of your project would you like help with?I welcome any constructive feedback. ð
Community feedback
- @vanzasetiaPosted over 2 years ago
Very nice work on this challenge, Darrick! ð
It's great to see you submit another great solution! ð It's responsive and looks good on both landscape and portrait mobile views! ð
I don't understand Vite however, I notice that the first section is wrapped with
header
tag which it should not. This site doesn't have aheader
. Normally,header
is going to have a logo andnav
element. The heading one should live inside themain
element (which commonly the heading for the hero section).Overall, great work and it's great that you added a cool hover effect on those cards. Keep up the good work! ð
Marked as helpful1@DarrickFauvelPosted over 2 years ago@vanzasetia Hi Vanza! ð
Thank you for the kind words. I always appreciate your helpful feedback.
Vite is very good and fast. I'm now using it instead of Parcel and Webpack. It also supports Sass out-of-the-box as they say. Vite website
Regarding the
header
, I guess I fell into the page pattern of applying a header, main, and footer. But, as this is a "section" project, I've now wrapped theheader
andcards
into asection
landmark. I think it works better as a section > header. Does that make sense? ðĪ·ââïļI just updated this solution and it is now more visually closer to the design and is using more CSS Open Props. Open Props ð
The hover effects are my way of having a little fun
transform
ing the design.Thanks again for the great feedback, Vanza! ð
1@vanzasetiaPosted over 2 years ago@DarrickFauvel I recommend still keeping the
main
and removing theheader
.header
inside thesection
element would have no meaning which means it doesn't make it more accessible and hurt the accessibility at the same time. It works likediv
. So, all the child elements of thebody
element would be landmark elements (main
andfooter
).Also, nice work with the update! It's amazing that it perfectly matches the design! ð
Keep up the great work! ð
Marked as helpful1@DarrickFauvelPosted over 2 years ago@vanzasetia Thanks for making that clarification about main, header, & section.ð I have made the correction.
Thanks for kind words about perfectly matching the design. I know the goal is not pixel perfection, but I try to get pretty close. Even if it makes me ðĪŠ.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord