Four Card Feature Section Component using SASS (Grid)

Community feedback

• 

  eruj22•410

  @eruj22Posted about 2 years ago

  Hi Osman,

  I had a look at your project and its code and saw some possibilities to improve your coding skills.

  Your deployed site breaks when viewing from the mobile. You could easily fix that with using flex instead of grid for card container. Code on GitHub looks good and it is structured well. Some comments were left out inside main.scss that don't belong in the high quality code. Also, your way of writing CSS classes looks similar to BEM methodology, but it isn't quite there yet. In the case of using BEM you would write something like "container__item" instead of currently used "container__cards__item". So, if you want to learn it better have a look at this great resource https://sparkbox.com/foundry/bem_by_example.

  Hope that you learn something new from my comment.

  Marked as helpful

  0

  ---

  

  Osman Nuri ERDOĞAN•330

  @osmannurierdoganPosted about 2 years ago

  Hi @eruj22,

  I will fix the errors and check the BEM out again. Also thanks for BEM link.

  Maybe you should see the mobile layout using devtool for 382px or less. Because I coded the mobile layout for 384px so that of course the design will break down at the screens which has more width. But thanks again I will change the layout anyway for any points where the design breaks down.

  Thanks for your comment. Take care :)

  0