Design comparison
Solution retrospective
Hello everyone, so this is my second challenge here, I'm not comfortable with my solution and I'm hoping you guys could guild me or correct my mistakes. Thank you.
Community feedback
- @janegcaPosted almost 4 years ago
Hi Bluebhot, overall your design looks pretty good and is fairly responsive although you might want to add another breakpoint for the mid-range sizes.
One thing I would suggest is re-thinking the way you are naming sections and using id's for everything. For instance instead of
first-section
,id=first-h2
,id=second-h2
try something likeheader
,header > h2:first-of-type
or perhaps, rather than using heading tags usespan
,h1
,p
so you can target them asheader > span
,header > h1
, etc. As a general rule of thumb, id's are usually limited to anything you want to directly target with JS or for an exception-to-the-rule CSS style.Hope that's of some help. Happy coding.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord