Skip to content
Submitted almost 2 years ago

Four card feature selection

Abdu-rahman•20
@abdurahmanjabiin
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I did it using CSS grid with flex, it was my first time doin such grid challenge, I'm still not good using both flex and grid together, I struggled for while position the icons, I wanted 2 line of space between the text and the icons, a lot of improvement needed.

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted almost 2 years ago

    Hey there! 👋 Here are some suggestions to help improve your code:

    Congrats on completing your first challenge! 🎊

    • Your **HTML should have ** a main element that will assist in identifying the main content of your site, which in this case it will be the entire card section.

    More Info:📚

    MDN Main Element

    • The intro heading and paragraph should be wrapped inside a header element.
    • The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single h1 heading along with a span element.
    • Using CSS Grid with Grid-Template-Areas will make things way easier when building the layout; it will give you full control of the layout.

    Here is an example of how it works: EXAMPLE

    • Implement a Mobile First approach 📱 > 🖥

    With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

    • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

    Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

    https://www.joshwcomeau.com/css/custom-css-reset/

    https://meyerweb.com/eric/tools/css/reset/

    http://html5doctor.com/html-5-reset-stylesheet/

    If you have any questions or need further clarification, feel free to reach out to me.

    Happy Coding!🎄🎁

    Marked as helpful
    1
    Abdu-rahman•20
    @abdurahmanjabiinPosted almost 2 years ago

    @vcarames thanks for the feedback, took notes, and I will do my best to improve my code.

    1
    バレンタイン 😈•64,170
    @VCaramesPosted almost 2 years ago

    @abdurahmanjabiin

    Glad I could help!☃️

    Keep it up!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord