Design comparison
Solution retrospective
any suggestions for improvement are welcome!
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @Gabriela-hub-89, Congratulations on completing this challenge!
Iโve few suggestions for you that you can consider adding to your code:
The box-shadow is a bit too strong, this is due the
opacity
andblur
. The secret to create a perfect and smooth shadow is to have low values foropacity
and increaseblur
try this value instead:box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);
If youโre not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/
โ๏ธ I hope this helps you and happy coding!
Marked as helpful0 - @edufelibugmPosted about 2 years ago
Hi @Gabriela-hub-89 !!! ๐ Your design looks good, but not it's responsive for mobile resolutions. ๐ฑ๐ฑ
It's very easy adjust that, only add
@media (max-width: /* resolution where it looks wrong */) { /*your CSS code*/ }
, then add the atributedisplay: flex; flex-direction: column;
in your class "cards". ๐คAnd that's it, you already have your design for mobile!!! ๐ฅณ ๐ฅณ ๐ฅณ
Have a great day and happy coding ๐
Marked as helpful0 - @jgreen721Posted about 2 years ago
Only suggestion would be to make it responsive to mobile. You can do that pretty easily with CSS
@media
query and you can adjust your grid to single column rows at a particular screen width.Something like
@media screen and (max-width:450px){ // your CSS code here}
. Make sure there is the white space betweenand
and the open(
. I've tripped over that gotcha more than once.Nice job on the challenge though. Looks great on the regular size screen!
Marked as helpful0@Gabriela-hub-89Posted about 2 years ago@jgreen721 Thanks! I knew I was forgetting to do something.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord