Four Card Feature Section

Community feedback

• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Great work on this! You should be proud. Here are a few observations that might help you improve further…

  • Using rem or em units in @media queries aswell, This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

  • Using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • Slipper slope changing the base font size, This can disrupt user accessibility settings, cause inconsistency across devices, and potentially make text harder to read, affecting usability and accessibility.

  • I think this is a over sight but I dont understand why you are using px & width instead of rem or max/min-width in some places like .card there is width: 100%; max-width: 350px;

  You smashed this solution out of the water in my opinion, You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  Marked as helpful

  1

  ---

  

  P

  biwwabong•140

  @biwwabongPosted about 2 months ago

  @Stroudy Thanks for the comments, you were correct, I had been lazy in checking my code, I was using pixels to eyeball the sizes and didn't change them. I have corrected the code now.

  Also thanks for the BEM link, I'm just reading up on it now :)

  1