Design comparison
Solution retrospective
Having the layout switch using grid for desktop and the simple task of the coloured border not wrapping around the border-radius.
What challenges did you encounter, and how did you overcome them?transform: translateY(50%); Simple but took me 2 hours to figure it out. Took the long way round :)
Community feedback
- @StroudyPosted 2 months ago
Great work on this! You should be proud. Here are a few observations that might help you improve further…
-
Using
rem
orem
units in@media
queries aswell, This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences. -
Using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
-
Slipper slope changing the base font size, This can disrupt user accessibility settings, cause inconsistency across devices, and potentially make text harder to read, affecting usability and accessibility.
-
I think this is a over sight but I dont understand why you are using
px
&width
instead ofrem
ormax/min-width
in some places like.card
there iswidth: 100%; max-width: 350px;
You smashed this solution out of the water in my opinion, You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful1@biwwabongPosted 2 months ago@Stroudy Thanks for the comments, you were correct, I had been lazy in checking my code, I was using pixels to eyeball the sizes and didn't change them. I have corrected the code now.
Also thanks for the BEM link, I'm just reading up on it now :)
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord