Design comparison
SolutionDesign
Solution retrospective
Please feel free to leave any comments.
Community feedback
- @mattstuddertPosted over 4 years ago
Awesome work, Inkz, and congrats on submitting your first solution to the platform! You've done a really good job matching it up to the design. Here are a couple of small pointers after taking a look at your code:
- You've used a
div
for the.card-title
elements, whereas I'd say they make more sense as headings. Seeing as your only other heading level is ah1
on this project,h2
headings would work well. - Avoid making your CSS selectors unnecessarily complex. For example, you've got
.cards-container .card .card-image
when you could just have.card-image
. This will help keep your styles more maintainable. Especially as you build larger and larger projects.
I hope this helps. Keep up the great work! 👍
0 - You've used a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord