Design comparison
SolutionDesign
Solution retrospective
Hi,
I completed this four card feature section within 2 hours. Is it too long time with react? Any feedback will be appreciated. 👍
Thank you.
Community feedback
- @grace-snowPosted almost 2 years ago
Hi
This looks good to me overall but there are some improvements to be made...
- change the alt on icons to be an empty string. They are definitely decorative images
- letter spacing must never be in px! Really important. Use em so it scales with the text
- it would be better if max width of container was in rem. Usually max widths on headings or paragraphs would be in ch
- it's unusual to need to change font sizes in media queries. I haven't seen the design files so maybe the designer wanted that to happen but it's unusual and usually unnecessary
- it's a real shame you've not done this with css grid. It's the perfect challenge for it! I recommend refactoring that if you can.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord