12th Challenge Four Feature-Card Design using HTML , CSS and FlexBox
Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The intro heading and paragraph should be wrapped inside a
header
element.
- The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single
h1
heading along with aspan
element.
- The
main
element should only be wrapping the card section since that is the main content of your page.
- The “icons” serve no other purpose than to be decorative; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Using
CSS Grid
withGrid-Template-Areas
will make things way easier when building the layout; it will give you full control of the layout.
Here is an example of how it works: EXAMPLE
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@ar-refaiPosted almost 2 years ago@vcarames Thank you very much Vcarames That was really helpful ,I'am sure your comment will benefit me not in this challenge only but the next challenges as well.
1@VCaramesPosted almost 2 years ago@Abdelrahman-Elrefai
Glad I could help!
Keep it up!
1@ar-refaiPosted almost 2 years ago@vcarames I have edited it except for the grid point you mentioned and in next challenges I will try to use grid more.
0@VCaramesPosted almost 2 years ago@Abdelrahman-Elrefai
CSS
grid
, once mastered, is the best tool you can use. It makes complicated layouts easy to do.1 - The intro heading and paragraph should be wrapped inside a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord