Four card feature section

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful! 😊

  Make sure to wrap the entire code in the main tag instead of section. It will help to remove report issues and improve accessibility as well. If you are using, for example, header or footer tags, you can place them outside the main tag.

  I believe the text's Reliable, efficient delivery & Powered by Technology should be the same text and wrapped in h1.

  The images on the cards should be used more as a decorative images, rather than being attached to any content.

  Alt attribute for the image is important in order to specify alternative text for the image in case it will not be displayed. Using alt attribute is good for not only accessibility but also SEO and for situations when the image is loading too slowly. 
If the image is just for decoration you can still write an alt attribute but leave it empty, such images don’t need any alt tag but you will need to also add aria-hidden=“true”. What aria-hidden does is that it removes the entire element from the accessibility tree.

  If otherwise, you need to use an alt tag to describe the image. To write an alt tag you need to describe the content and purpose of the image and try not to use words like “picture of” or “image of”.

  0

  ---

  

  Faith•420

  @fnworkPosted almost 2 years ago

  @catherineisonline Thank you so much I will add the corrections to my git hub code

  0
• 

  chucksterv•220

  @chuckstervPosted almost 2 years ago

  Hey mate, your code looks good. Congratulations on completing the challenge.

  A couple of things I would do differently.

  • As far as I know, floats are mostly not in use unless absolutely necessary. I did a quick search and it seems the only use case for it is when you need text to wrap around something which isn't a requirement here. For the image I would give it a margin-left: auto to align it to the right.

  • I would consider using a grid instead of flex for positioning. While there is absolutely nothing wrong with using flex for this use case, I feel Grid would be a better way to approach it specially when it comes to responsive design.

  Hope that helps! Happy Coding!

  0

  ---

  

  Faith•420

  @fnworkPosted almost 2 years ago

  @chucksterv Thanks a lot

  0