Four card feature section (flexbox and grid)

Community feedback

• 

  Jordan Phillips•425

  @JordanPhillips-hubPosted almost 2 years ago

  Hey Maciej I like your solution a couple of things I would consider changing is there should only be one <h1> tag on a page I would change this and use a span like this to avoid using two <h1> tags <h1 header__title> Reliable, efficient delivery <br/> <span header__title--dark>Powered by Technology</span>

  </h1> Also, consider changing your <h3> tags to <h2> tags and adjusting the font size with CSS as heading levels should increase by one for accessibility reasons.

  0

  ---

  

  Maciej•30

  @MacstorkPosted almost 2 years ago

  @JordanPhillips-hub Thank you so much for these advices. I didn't know that h1 tag should be only one per page. I' ve implemented all changes you mentioned.

  0

  

  Jordan Phillips•425

  @JordanPhillips-hubPosted almost 2 years ago

  @Macstork Although opinions differ, some say having any number of <h1> tags is fine, and others say the opposite. Using only one H1 creates a hierarchy and gives your page a more logical structure. It makes it easy for readers (and those using screen readers) to skim and understand what your page is about. Each page should have only one main topic and headline. There are Lots of different articles on this topic, but this makes the most sense to me, so I like to follow this.

  0

  

  Maciej•30

  @MacstorkPosted almost 2 years ago

  @JordanPhillips-hub Yes, you are right. I learned about it, but I forgot to implement it in real project. I will remember about this matter in future. I really appreciate your feedback ;)

  0