Design comparison
Community feedback
- @Alex-Archer-IPosted 5 months ago
Hi!
Your work is quite neat, congrats with finishing it =)
I can give a couple of suggestions.
First of all, a few semantic tips. There should be only one
h1
element on the page. And it should be insidemain
tag, notheader
. Top levelheader
is for page navigation, site logo and stuff. Here all content should be insidemain
(and you actually doesn't need a wrapper for it).And I want to say, that if you used grid that you didn't have to wrap two middle elements in additional wrapper. It's cool if you wanted to practice flex more, I just suggest you a bit more convenient way =)
Hope that helps. Keep doing cool stuff =)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord