Design comparison
Solution retrospective
Hi! 💪😁🤙 Any feedback is welcome! 🔁🙏
Community feedback
- @GrzywNPosted about 2 years ago
https://www.youtube.com/playlist?list=PLjHmWifVUNMLJqo4jyY5UKJefNmH3Vslu https://www.youtube.com/playlist?list=PLjHmWifVUNMKIGHmaGPVqSD-L6i1Zw-MH
tam masz fajne poradniki do bem i gita, jak chcesz zeby ci pisali komentarze to sobie daj do nazwy czego używałeś np. Four Card Feature Section | HTML, SCSS with BEM
Marked as helpful0 - @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your
body
element (this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
More Info:📚
- The "header__subtitle" is not a heading it is a paragraph, so it should be wrapped in a.
paragraph
element.
- The
article
element is not the best choice for wrapping each individual card. In order to use thearticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site).
- The “icons” serve no other purpose than to be decorative; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
- Using
CSS Grid
withGrid-Template-Areas
will make things way easier when building the layout; it will give you full control of the layout.
Here is an example of how it works: EXAMPLE
- Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0 - To properly center your content to your page, you will want to add the following to your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord