Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
article
element is not needed for this challenge since none of the components can stand on their own.
- The “Reliable, efficient delivery Powered by Technology” is one single heading so the entire thing should be wrapped in a single
h1
heading along with aspan
element.
- The
header
element should only be wrapping the intro heading and paragraph.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@Emir-SezerPosted almost 2 years ago@vcarames I may need more help with semantic tags Thank you 👍
0 - The
- @Nadine-GreenPosted almost 2 years ago
HEY EMIR!
I ABSOLUTELY LOVE THE EXTRA DETAILS AND EFFECTS YOU ADDED TO YOUR SOLUTION, VERY NICE
I noticed that you have some accessibility errors, a quick fix to some of those errors would be to give the images an empty alt, you should also add the code
aria-hidden: true
, what this code does is tell screen readers to ignore the image as It serves no purpose and is only meant to be decorative.IF THIS WAS HELPFUL IN ANY WAY, DON'T HESITATE TO MARK IT AS HELPFUL :)
HAPPY CODING!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord