Skip to content
Submitted over 1 year ago

Four card feature section

I_am_learner•110
@iamlearner0
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello bosses. I just finished the "Four card feature section" challenge. Any feedback, suggestion or correction will be greatly appreciated. Thank you!

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
    • So fix it by replacing the <div class="main"> element with the semantic element <main> along with <div class="header"> into a <header> element in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    I_am_learner•110
    @iamlearner0Posted over 1 year ago

    @0xAbdulKhalid Thank you for the comment. It's a motivation that I can do better and I will surely work on your observations.

    0
  • Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    Hi there!

    I recommend only wrapping "Reliable, efficient delivery Powered by Technology" with one <h1>. It should be read as one sentence instead of two sentences.

    All the icons are decorative images. So, you should leave the alternative text empty.

    You should set the <body>'s font size with rem unit instead of px.

    Never use px unit for font sizes. Learn more — Why you should never use px to set font-size in CSS

    I hope this helps.

    Marked as helpful
    0
    I_am_learner•110
    @iamlearner0Posted over 1 year ago

    @vanzasetia Thank you for your observation. I will surely take note and make corrections

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord