Design comparison
Solution retrospective
Please give feedback on my solution.
Community feedback
- @sonickonicPosted over 4 years ago
Congrats on submitting your first solution! it looks amazing!
You've currently got two h1 elements, it will be better to use it once as it can cause accessibility issues. Two ways to solve it:
- Wrap all of that text as a single h1 and use a span element inside it to separate the text.
- Use h1 for the main heading and h2 for the sub-title.
Although it is a pixel perfect solution for the wide-screen, the mobile version is slightly off. Try next time to use min-width media queries instead of max-width. Starting from the mobile-first can lead to more simple solution)
Good job!
3@aayush182Posted over 4 years agoHi, @sonickonic. Thanks for your kind suggestion.
Since I'm new to programming, I'm trying to keep practising, gaining knowledge and trying to explore more new kinds of stuff.
1@sonickonicPosted over 4 years ago@aayush182 for someone new to programming, You nailed it! Did you choose already your next challenge?
1@aayush182Posted over 4 years ago@sonickonic thank u again, and so far I haven't chosen anything.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord