Design comparison
Solution retrospective
All feedbacks are welcome
Community feedback
- @correlucasPosted about 2 years ago
👾Hi Trvan Quan, congrats on completing this challenge!
Here’s some tips to improve your component design:
1.The value you’ve used for the shadow make it too much dark and strong. To improve your box-shadow, you’ve to have in mind two things that make a good shadow,
blur
andlow opacity
for smooth shadows. To improve your current shadow, decrease theopacity
and increase theblur
, try this value instead:box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);
If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/
2.You made your html structure entirely with
div blocks
but these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for each card you use<article>
instead of the<div>
.✌️ I hope this helps you and happy coding!
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord