Design comparison
SolutionDesign
Community feedback
- @Alex-Archer-IPosted 4 months ago
Hi!
Cool work, congrats =)
The one thing - the pictures in the mobile version is beyond the borders of the card. It happens cos of
float
property. This property is a bit unpredictable and rarely use nowadays.You can align picture by changing the display of the card to
flex
(flex-direction: column
) and usingalign-self
to picture. Also you can usemargin-left: auto
on the picture.And I guess semantically correct would be to use
ul
tag for card container andli
for card items.Overall I like your clear code structure. Neat work, keep doing =)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord