Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?Setting the right dimension for the main container.
What specific areas of your project would you like help with?If anyone has any suggestions in general or regarding the sizing of the main box, that of the element, it will be really appreciated. Thank you :)
Community feedback
- @MajdMohammedPosted 6 months ago
Some feedback:
- I noticed that you don't use semantic elements, it helps the browser to understand better your HTML structure.
- h1 instead of h2 will be nice for a proper HTML structure.
- The font size is too different than the font size on the design given, try to set an accurate font size
- For the headers inside the cards try to use h2 instead of div, to give your structure a meaning
- sometimes using main as container and section as child container is way better than using div.
- your shadow box looks too different, it needs to be a bit closer to the design
I hope my feedback is useful Happy coding !
Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord