Four Card Features Sections

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted almost 2 years ago

  Hi there 👋:

  • You just completed a solution as per the design Congratulations..🙌
  • But, There's some report in accessibility which causes accessibility error

  RESOLVING THE ERROR

  • The div with class .container is meant to be a main element
  • Because using semantical elements to structure the HTML improves the accessibility for screen readers
  • So change the div into main element
  • And finally, consider to remove the .attribution (footer) for better viewing experience

  GREETINGS:

  • Happy coding..🙌
  • Peace be upon you with god's mercy & blessings..✨

  1

  ---

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @0xAbdulKhalid

  Please avoid the following as it is against FEM’s policy:

  • If my answer helps you then providing an upvote will be very helpfull
  • And don't forget to mark this comment as helpfull. If it helps to resolve your issues

  Which can result in your getting account flagged and ban temporarily or permanently.

  "Ask people to mark your comment as helpful — A big part of Frontend Mentor is helping each other out and providing feedback. If you give some feedback, please avoid saying things like, "if you found this feedback useful, please mark this comment as helpful". It places unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided. Feel free to say something like, "I hope you find this helpful", but please avoid asking for your comment to be marked as helpful outright."

  Remember, it’s about helping each other grow and become better developers, not about getting points.

  Thank you for contributing to the FEM community!

  Happy Coding!🎄🎁

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted almost 2 years ago

  @vcarames Thank you for reminding me regarding that stuff, hereafter i will follow the fem's policy

  1
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “Icons” serve no other purpose than to be decorative; They add no value. Their alt tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Using CSS Grid with Grid-Template-Areas will make things way easier when building the layout; it will give you full control of the layout.

  Here is an example of how it works: EXAMPLE

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0