Design comparison
Solution retrospective
Hi there, I have just finished this project. I will be happy to hear any feedback and tips.
Community feedback
- @ratul0407Posted about 1 year ago
@Amens11 congratulations on completing this challenge🎉🎉
The solution looks great. But one thing I want to say is, Avoid pixels as much as you can. You've set a
gap:25px
you can do it withrems
like,gap:1.56rem
. Use pixels for small values like forborder
,box-shadow
,drop-shadow
where you have to use 1, 2 or 5 pixels, the value forrems
would to too small for these use cases and 1 or 2 pixel won't have that much impact on your work. Overall the solution is pretty goodKEEP UP THE GOOD WORK👍👍
Marked as helpful0@Amens11Posted about 1 year ago@ratul0407 Thank you for your feedback and the time to check my code. I will update my code.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord